BUG: Do not crash on recursive .dtype attribute lookup.
#13982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code path in scalarapi.c which checks dtype on one inheriting from np.void is especially awkward and was completely untested previously. So I am not sure we should even support it at all. Closes numpygh-12982, numpygh-3614, and numpygh-12751
mattip
reviewed
Jul 14, 2019
| PyErr_Clear(); | ||
| return 0; | ||
| } | ||
| return 1; |
There was a problem hiding this comment.
Compilation is failing on Python2.7 since PyExc_RecursionError does not exist. Py_EnterRecursiveCall raises PyExc_RuntimeError instead
|
We need to choose between fixing the error and not backporting. I would vote for not backporting |
Sounds good to me. It was an iffy backport candidate to start with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13003
The code path in scalarapi.c which checks dtype on one inheriting
from np.void is especially awkward and was completely untested
previously. So I am not sure we should even support it at all.
Closes gh-12982, gh-3614, and gh-12751