New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add quantile support for datetime64 #11627
Conversation
a9b5772
to
54e27f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be helpful to add some tests to this potential contribution as well--I see that you've started discussing input and expected output with Eric in the linked issue so that might be a starting point.
@tylerjereddy, testcase added. Travis CI reports false fail, please rebuild. |
Ok, I restarted the failing Python 3.7 job in Travis |
A couple of thoughts:
|
New commit with using view and adding testcase. |
This is currently supported. However, I do not think we have any tests, so it would be great to recover (and maybe add to those). It may be tested downstream but I am not certain. There is also the question of rounding that was brought up here, I am not immediately sure if this is a problem with our linear interpolation formula and datetime/timedelta inputs; it might be nice to vet it. The handling of NaT is still broken, I suspect the fix should be closer to what we do for |
@eric-wieser, Is this OK? No explicit rounding.
close #11620