Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release date after delay #9569

Merged
merged 1 commit into from May 11, 2024

Conversation

esc
Copy link
Member

@esc esc commented May 10, 2024

As title

@esc esc added this to the 0.60.0-rc1 milestone May 10, 2024
@guilhermeleobas
Copy link
Collaborator

@esc, should one add the skip-releases-note label?

@esc esc added the skip_release_notes Skip towncrier requirement label May 11, 2024
@esc
Copy link
Member Author

esc commented May 11, 2024

@esc, should one add the skip-releases-note label?

Yes, but wanted to wait until Azure is done. I find that the only way to re-run testing after adding the label is to open/close the issue which then creates a backlog for CI. The situation is far from ideal. I've added it now.

@esc esc merged commit 1d4368b into numba:release0.60 May 11, 2024
20 of 21 checks passed
@esc
Copy link
Member Author

esc commented May 11, 2024

@esc, should one add the skip-releases-note label?

Yes, but wanted to wait until Azure is done. I find that the only way to re-run testing after adding the label is to open/close the issue which then creates a backlog for CI. The situation is far from ideal. I've added it now.

Oh I accidentally clicked "merge" rather than "close". Well, I guess that's a first. Feel free to retroactively approve the PR or disapprove it and I'll make another one. I was able to merge without a review, because branch protection is only on for the main branch..

@guilhermeleobas
Copy link
Collaborator

Can't approve it anymore as the PR was merged.

@esc
Copy link
Member Author

esc commented May 13, 2024

Can't approve it anymore as the PR was merged.

Hmmm, we should activate branch protections for release branches too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants