Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin versions for release0.59 #9371

Merged
merged 5 commits into from Dec 14, 2023
Merged

Pin versions for release0.59 #9371

merged 5 commits into from Dec 14, 2023

Conversation

sklam
Copy link
Member

@sklam sklam commented Dec 14, 2023

as titled

@sklam sklam marked this pull request as ready for review December 14, 2023 17:58
@sklam sklam added the skip_release_notes Skip towncrier requirement label Dec 14, 2023
stuartarchibald
stuartarchibald reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, couple of queries else looks good.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@sklam @stuartarchibald
Apply suggestions from code review
74166ce 
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
stuartarchibald
stuartarchibald reviewed Dec 14, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
stuartarchibald
stuartarchibald approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. This looks good on inspection, code change is approved conditional on CI passing!

@stuartarchibald stuartarchibald added the 4 - Waiting on CI Review etc done, waiting for CI to finish label Dec 14, 2023
@stuartarchibald stuartarchibald added this to the 0.59.0-rc1 milestone Dec 14, 2023
@sklam
Copy link
Member Author

sklam commented Dec 14, 2023

Buildfarm CPU smoketest, GPU smoketest, and wheel builder has passsed.

@sklam sklam merged commit 437b91b into numba:release0.59 Dec 14, 2023
21 checks passed
@sklam sklam deleted the misc/relese0.59prep branch December 14, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

Assignees
No one assigned
Labels
4 - Waiting on CI Review etc done, waiting for CI to finish skip_release_notes Skip towncrier requirement
Projects
None yet
Milestone
0.59.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sklam @stuartarchibald