Update TBB to use >= 2021.6 by default. #8856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved conflicts in: numba/np/ufunc/tbbpool.cpp
Fixed conflicts in: numba/np/ufunc/tbbpool.cpp
Updates buildscripts, source and docs in relation to TBB 2021.6. * Windows 32 bit doesn't have the parallel target enabled so doesn't need TBB. * ppc64le and linux-aarch64 have suitable packages available but these haven't been tested so exclude them for now. * Updates the TBB version checking code for 2021.6 as minimum.
|
BFID |
sklam
added
the
Pending BuildFarm
sklam
approved these changes
Mar 29, 2023
| #error "TBB version is incompatible, 2021.1 through to 2021.5 required, i.e. 12010 <= TBB_INTERFACE_VERSION < 12060" | ||
| /* TBB 2021.6 is the minimum version */ | ||
| #if (TBB_INTERFACE_VERSION < 12060) | ||
| #error "TBB version is incompatible, 2021.6 or greater required, i.e. TBB_INTERFACE_VERSION >= 12060" |
There was a problem hiding this comment.
manually confirmed that this check works as expected.
sklam
added
4 - Waiting on CI
2 tasks
sklam
added
BuildFarm Passed
sklam
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates buildscripts, source and docs in relation to TBB 2021.6.
so doesn't need TBB.
these haven't been tested so exclude them for now.
This is a continuation of PR #8727 which in itself is a continuation of #7608.
Closes #8487