- remove setuptools dependency #7687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mediate step before droping setuptools dependency
franzhaas
requested review from
esc,
sklam and
stuartarchibald
as code owners
|
Many thanks for the PR! I've queued it for review. I do need to go back and get #5209 over the line - it got a bit fiddly so I didn't yet find a good moment to get everything as it should be. |
|
@franzhaas Is this PR still applicable now #5209 is merged? It seems like it makes a similar set of changes to achieve similar goals. |
|
Sry for the late reply. I did not check, but this would be extremely unlikely as this is a derived work of the mentioned pull request. |
|
@franzhaas thanks for checking back and electing to close. #5209 should gain the same performance improvement, please do check 0.56 when it's released and report any issues in relation to this. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to numba/llvmlite#801 (comment), this is an effort to remove usage / dependency of setuptools.
The motivation is that it makes it easier to use tools like pyoxidizer, replaces a library dependency with a builtin depenency, decreases import latency and reduces overall dependancies.
also like the mentioned pull request, not a killer feauture not a bug fix, but it is expected to speedup import times.
At some point i noticed the PR fix/4927-slow-import and used the developoments from there.
This is not a successfull simplification. A dependency of a backport and two implementations how to find the entrypoints have been added. On the other side the dependancy of setuptools and 1 implementation got removed.
If this yields improvements on importtime, it propably is still be worth it, especially for python 3.8 and newer. Also for me personaly droping setuptools as a requirement is a big plus as packages tend to use it if it is there, which ocationally causes issues...
I used input from: python/importlib_metadata#298
And again, the original PR from @svrakitin.
These code changes would need to be touched when suport for 3.7 and 3.8 gets removed.
Unfortunately I was unable to test it with real extensions.