Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 0.45.0RC1 release changelog #4297

Merged
merged 6 commits into from
Jul 10, 2019
Merged

Conversation

sklam
Copy link
Member

@sklam sklam commented Jul 9, 2019

as titled.

@seibert seibert added this to the Numba 0.45 RC milestone Jul 9, 2019
@seibert seibert mentioned this pull request Jul 9, 2019
10 tasks
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This is a pretty much there but it seems like a few things were missed, noted in comments. Thanks.

Joshua Adelman added support for ``x in range(...)`` in #4129.


General Enhancements:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be missing a bunch of PRs...

$ git log 0.45.0dev0..HEAD|grep -i "Merge pull"|egrep -i "#[0-9][0-9]+"|wc -l

shows 60, I manually cross referenced these against those on the milestone (which was not complete in itself, but is now).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my script stopped prematurely. the list of PR has been fixed now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see these anywhere:

Also, I just noticed that this proposed change log update is stylistically inconsistent with the records since 0.35.0, from then on the PRs are ordered from lowest ticket number to highest, this one does highest to lowest.

CHANGE_LOG Outdated Show resolved Hide resolved

Joshua Adelman added support for ``x in range(...)`` in #4129.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucio Fernandez-Arjona added support for np.select in #4077
Rob Ennis added support for np.flatnonzero in #4157

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've updated the contributors

CHANGE_LOG Outdated Show resolved Hide resolved
CHANGE_LOG Outdated Show resolved Hide resolved
CHANGE_LOG Outdated
Version 0.45.0
--------------

In this release, Numba gained an experimental `numba.typed.List <pending_link>`_ container as a future replacement of the `reflected list <pending_link>`_. In addition, functions decorated with ``parallel=True`` can now be cached to reduce compilation overhead due to the auto-parallelization the function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this release, Numba gained an experimental `numba.typed.List <pending_link>`_ container as a future replacement of the `reflected list <pending_link>`_. In addition, functions decorated with ``parallel=True`` can now be cached to reduce compilation overhead due to the auto-parallelization the function.
In this release Numba gained an experimental `numba.typed.List <pending_link>`_ container as a future replacement of the `reflected list <pending_link>`_. In addition, functions decorated with ``parallel=True`` can now be cached to reduce compilation overhead associated with the auto-parallelization the function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma is not needed after "release"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you, I'm not sure it needs it, but it's the most minor of details :) either way is fine. Was more concerned with the due to at the end of the line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed due to, kept comma.

CHANGE_LOG Outdated Show resolved Hide resolved
CHANGE_LOG Outdated Show resolved Hide resolved
CHANGE_LOG Outdated Show resolved Hide resolved
@seibert seibert merged commit 35767c7 into numba:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants