Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/vanilla ae refactor #379

Merged
merged 27 commits into from
May 14, 2024
Merged

Feat/vanilla ae refactor #379

merged 27 commits into from
May 14, 2024

Conversation

ab93
Copy link
Member

@ab93 ab93 commented May 9, 2024 •
edited

  • Refactor Vanilla AE
  • Support static filters in Druid
  • Add Percentile Scaler

ab93 and others added 23 commits April 18, 2024 17:54
@ab93
feat: add PercentileScaler
f7bd30b 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: percentile scaler, exp mov avg, sigmoid norm (#369)
b36356c 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
correct struct log for ack_insuf_data
8321914 
Signed-off-by: Gulshan Bhatia <gulshan_bhatia@intuit.com>
@ab93
chore: bump version
88ccf66 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: C contiguous error for exp mov avg tx
5593be3 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
chore: bump version
5806a68 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
feat: fallback to stddev if threshold is too low
9ad6d8d 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: adjust factor
eed9ad4 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
chore: bump version
edcb9e6 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
feat: enable feature transforms
8b2e939 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
try: replicate og vanilla ae
cbf4dbd 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
chore: update version
6e41a79 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@s0nicboOm
fix: add threshold in metadata
f9ebfaf 
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm
Static filter (#373)
98c5766 
Static_filters support

---------

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@nkoppisetty
feat: multi column pivot for druid connector (#374)
e1ae3ee 
Explain what this PR does.

Implemented pivot with multiple columns in druid connector

---------

Signed-off-by: Nandita Koppisetty <nandita.iitkgp@gmail.com>
@s0nicboOm
Postproc support for None (#375)
141e9a0 
Support for None for postproc.

---------

Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
@nkoppisetty
Fix: Changing pivot to pivot_table to support aggregation (#376)
402aabf 
Explain what this PR does.

Changing pivot to pivot_table to support aggregation

---------

Signed-off-by: Nandita Koppisetty <nandita.iitkgp@gmail.com>
@nkoppisetty
feat: agg from conf for multi pivot (#378)
984650b 
Explain what this PR does.

Adding agg to pivot config for multi pivot

---------

Signed-off-by: Nandita Koppisetty <nandita.iitkgp@gmail.com>
@s0nicboOm
fix: threshold and filters
bbcfd47 
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
@s0nicboOm
fix: filters
87c16da 
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
@s0nicboOm @ab93
fix: filters
6f46250 
Signed-off-by: Kushal Batra <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
Merge branch 'main' into feat/postproc-order
b20f343
@ab93
fix: boto3 import
83633ed 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited

Codecov Report

Attention: Patch coverage is 86.27451% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 92.52%. Comparing base (f29f771) to head (3c4df81).

Files Patch % Lines
numalogic/connectors/druid/_druid.py 53.33% 12 Missing and 2 partials ⚠️
numalogic/transforms/_scaler.py 83.33% 4 Missing and 2 partials ⚠️
numalogic/backtest/_prom.py 81.25% 1 Missing and 2 partials ⚠️
numalogic/models/autoencoder/variants/vanilla.py 94.87% 0 Missing and 2 partials ⚠️
numalogic/udfs/postprocess.py 83.33% 1 Missing and 1 partial ⚠️
numalogic/connectors/__init__.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   93.07%   92.52%   -0.55%     
==========================================
  Files          97       98       +1     
  Lines        4492     4603     +111     
  Branches      387      407      +20     
==========================================
+ Hits         4181     4259      +78     
- Misses        231      252      +21     
- Partials       80       92      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ab93 ab93 marked this pull request as ready for review May 10, 2024 22:59
@ab93 ab93 requested a review from gulshan02 May 13, 2024 18:44
s0nicboOm
s0nicboOm reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

numalogic/models/threshold/_median.py Outdated Show resolved Hide resolved
numalogic/models/threshold/_static.py Show resolved Hide resolved
numalogic/transforms/_movavg.py Show resolved Hide resolved
numalogic/transforms/_movavg.py Show resolved Hide resolved
numalogic/backtest/_prom.py Outdated Show resolved Hide resolved
ab93 added 4 commits May 13, 2024 17:55
@ab93
fix: comments
1f0f6c9 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
docs: update exp
a9512d9 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
chore: add more coverage
f113194 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
chore: add more unit tests
3c4df81 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 requested review from s0nicboOm and gulshan02 May 14, 2024 03:20
s0nicboOm
s0nicboOm approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

gulshan02
gulshan02 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@gulshan02 gulshan02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ab93 ab93 merged commit 934d8cf into main May 14, 2024
11 checks passed
@ab93 ab93 deleted the feat/vanilla-ae-refactor branch May 14, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gulshan02 gulshan02 gulshan02 approved these changes

@s0nicboOm s0nicboOm s0nicboOm approved these changes

@qhuai qhuai Awaiting requested review from qhuai qhuai is a code owner

@nkoppisetty nkoppisetty Awaiting requested review from nkoppisetty nkoppisetty is a code owner

Assignees

@ab93 ab93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ab93 @gulshan02 @s0nicboOm @nkoppisetty