feat: colored logging formatter #348
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 92.31% 92.39% +0.07%
==========================================
Files 82 82
Lines 3918 3931 +13
Branches 325 325
==========================================
+ Hits 3617 3632 +15
+ Misses 233 230 -3
- Partials 68 69 +1 ☔ View full report in Codecov by Sentry. |
qhuai
reviewed
Feb 17, 2024
| super().__init__(*args, **kwargs) | ||
| self._formats = { | ||
| logging.DEBUG: f"{self.BLUE}{self._fmt}{self.RESET}", | ||
| logging.INFO: f"{self.WHITE}{self._fmt}{self.RESET}", |
There was a problem hiding this comment.
Do we ensure that the text background won't be WHITE as well?
| } | ||
|
|
||
| def format(self, record): | ||
| self._style._fmt = self._formats.get(record.levelno) |
There was a problem hiding this comment.
Do we need to prepare for the case when a new / typo logging level is introduced?
vigith
reviewed
Feb 17, 2024
I think we should add this switch. Apparently windows OS also have problem with colors. I remember that "loguru" added external library called "colorama" to solve for Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #312