Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced __internal__ argument with warning filters #19

Merged
merged 1 commit into from Jul 1, 2022

Conversation

radarhere
Copy link

Suggestion for #6381

@nulano
Copy link
Owner

nulano commented Jul 1, 2022

LGTM, except that warnings.catch_warnings is not thread-safe.

https://docs.python.org/3/library/warnings.html#warnings.catch_warnings

Note: The catch_warnings manager works by replacing and then later restoring the module’s showwarning() function and internal list of filter specifications. This means the context manager is modifying global state and therefore is not thread-safe.

@hugovk is this OK?

@nulano nulano merged commit 8a6050e into nulano:deprecate-getsize Jul 1, 2022
@nulano
Copy link
Owner

nulano commented Jul 1, 2022

Thank you both

@radarhere radarhere deleted the deprecate-getsize-catch branch July 1, 2022 12:11
nulano pushed a commit that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants