Crop offset with or without bbox argument #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The offset is just used to adjust the bbox coordinates; it is equal to the (Windows) screen coordinates of the top-left pixel, which may be negative. It is not used to crop the image by itself. The correct bbox for the whole screen is therefore Perhaps this confusion is caused by the name |
|
Thanks for your explanation |
nulano
pushed a commit
that referenced
this pull request
Jan 1, 2020
Corrected short and long range checks
nulano
pushed a commit
that referenced
this pull request
May 9, 2020
Changed default offset for Exif
nulano
pushed a commit
that referenced
this pull request
Jul 9, 2020
Updated documentation; Simplified code
radarhere
pushed a commit
that referenced
this pull request
Feb 22, 2021
Fixed unexpected indentation
nulano
pushed a commit
that referenced
this pull request
Aug 2, 2021
Save in ICNS format to support all operating systems
nulano
pushed a commit
that referenced
this pull request
Aug 2, 2021
Added test and flush file pointer
nulano
pushed a commit
that referenced
this pull request
Jan 31, 2022
Improved batch processing example in tutorial
nulano
pushed a commit
that referenced
this pull request
May 24, 2022
CI: Add a Cygwin run to GitHub Actions There are still a few things that are weird, but this looks much better than what I have now.
nulano
pushed a commit
that referenced
this pull request
May 24, 2022
* Removed unused import * Restored existing checks * Restored coerce_e, _E and data property * Deprecated coerce_e Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
nulano
pushed a commit
that referenced
this pull request
Jun 19, 2022
Only test alpha channel values
radarhere
pushed a commit
that referenced
this pull request
Jun 30, 2022
radarhere
pushed a commit
that referenced
this pull request
Sep 21, 2022
…in-finding-new-size Round position in pad()
nulano
pushed a commit
that referenced
this pull request
Oct 2, 2022
Improved palette handling in ImageOps
nulano
pushed a commit
that referenced
this pull request
Mar 5, 2023
nulano
pushed a commit
that referenced
this pull request
Jun 24, 2023
Call init() if mimetype is not found with preinit()
nulano
pushed a commit
that referenced
this pull request
Oct 9, 2023
Added custom before_install to temporarily pin wheel to 0.31.1
nulano
pushed a commit
that referenced
this pull request
Oct 9, 2023
_decoder.get_next() may return None
nulano
pushed a commit
that referenced
this pull request
Oct 9, 2023
Last trailer comment has priority
nulano
pushed a commit
that referenced
this pull request
Nov 25, 2023
Do not assign new fp attribute to image when closing
nulano
pushed a commit
that referenced
this pull request
Nov 27, 2023
Add tests for glyph alpha blending
radarhere
pushed a commit
that referenced
this pull request
Mar 2, 2024
Test error is raised without LOAD_TRUNCATED_IMAGES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python-pillow#3950
Correct me if I'm wrong - if you're going to crop the offset from the image, then it would seem that you should crop it whether or not there is a
bboxargument given by the user.