Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package source name #1356

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

werwolfby
Copy link
Contributor

Default global nuget.config uses nuget.org as key.

In my case this global nuget.config has private source, and special packageSourceMapping to use my private source for some packages. And use nuget.org as default one for everything else:

  <packageSourceMapping>
    <packageSource key="nuget.org">
      <package pattern="*" />
    </packageSource>
    <packageSource key="werwolf.by">
      <package pattern="werwolfby.*" />
    </packageSource>
  </packageSourceMapping>

Because nuget.config specified api.nuget.org as default, my global one doesn't allow me to restore packages in nuke project. This fix returns everything how it should be.

There is the question if nuke requires nuget.config at all?

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@gtbuchanan
Copy link
Contributor

There is the question if nuke requires nuget.config at all?

I'll second this question. I also ran into this issue since I have package source mapping configured in my user-level NuGet.Config. I deleted NuGet.Config locally from the Nuke repository to move forward with my PR, but I suppose this rename would have worked as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants