Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finalize changelog #1250

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

sandrofigo
Copy link
Contributor

@sandrofigo sandrofigo commented Sep 1, 2023

This PR fixes the wrong behavior when calling FinalizeChangelog() where the version summary would be repeated, as seen here.
A unit test has been added to confirm the behavior.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@sandrofigo sandrofigo force-pushed the fix-finalize-changelog branch 3 times, most recently from 0994b8b to 5cf2f18 Compare September 5, 2023 06:55
@sandrofigo
Copy link
Contributor Author

@matkoch This should fix the parsing problem when finalizing the changelog as discussed in #1130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants