New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest uvicorn version #324
Conversation
This pull request has been linked to Shortcut Story #2794: Adapt to latest uvicorn version. |
Codecov ReportBase: 67.27% // Head: 67.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 67.27% 67.25% -0.03%
==========================================
Files 209 209
Lines 14089 14089
==========================================
- Hits 9479 9475 -4
- Misses 4610 4614 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing debug is bot replaced for some other parameter on uvicorn?
(sorry, I should have included this as part of the description) no, it is not replaced by anything. According to encode/uvicorn#1640, the parameter wasn't really used... and even less when you are using with starlette |
ed01645
to
9f99c5d
Compare
Description
Use latest uvicorn version
How was this PR tested?
Existing tests should cover it, and I started the reader and the writer servers locally