Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest uvicorn version #324

Merged
merged 1 commit into from Oct 21, 2022

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Oct 21, 2022

Description

Use latest uvicorn version

How was this PR tested?

Existing tests should cover it, and I started the reader and the writer servers locally

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #2794: Adapt to latest uvicorn version.

@lferran lferran requested a review from a team October 21, 2022 07:10
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 67.27% // Head: 67.25% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9f99c5d) compared to base (0f4dcff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   67.27%   67.25%   -0.03%     
==========================================
  Files         209      209              
  Lines       14089    14089              
==========================================
- Hits         9479     9475       -4     
- Misses       4610     4614       +4     
Flag Coverage Δ
ingest 51.03% <ø> (ø)
node-sidecar 68.43% <ø> (ø)
nucliadb 52.59% <ø> (ø)
reader 63.68% <ø> (ø)
search 83.12% <ø> (-0.32%) ⬇️
train 32.71% <ø> (ø)
utils 48.19% <ø> (ø)
writer 78.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nucliadb/nucliadb/run.py 58.82% <ø> (ø)
nucliadb_utils/nucliadb_utils/fastapi/run.py 0.00% <ø> (ø)
nucliadb/nucliadb/search/api/v1/search.py 77.89% <0.00%> (-4.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bloodbare bloodbare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing debug is bot replaced for some other parameter on uvicorn?

@lferran
Copy link
Contributor Author

lferran commented Oct 21, 2022

removing debug is bot replaced for some other parameter on uvicorn?

(sorry, I should have included this as part of the description)

no, it is not replaced by anything. According to encode/uvicorn#1640, the parameter wasn't really used... and even less when you are using with starlette

@lferran lferran force-pushed the ferran/sc-2794/adapt-to-latest-uvicorn-version branch from ed01645 to 9f99c5d Compare October 21, 2022 12:04
@lferran lferran merged commit db3701a into main Oct 21, 2022
@lferran lferran deleted the ferran/sc-2794/adapt-to-latest-uvicorn-version branch October 21, 2022 12:24
lferran added a commit that referenced this pull request Oct 21, 2022
lferran added a commit that referenced this pull request Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants