Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency vimeo/psalm to v5 #681

Merged
merged 7 commits into from
Feb 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Pygments==2.13.0
sphinx==1.8.6
git+https://github.com/fabpot/sphinx-php.git@v2.0.2#egg_name=sphinx-php
sphinx_rtd_theme==1.0.0
sphinx_rtd_theme==1.1.1
jinja2==3.0.3
30 changes: 30 additions & 0 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,51 @@ parameters:
count: 1
path: src/Action/CheckEmailAction.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Console\\\\Helper\\\\HelperInterface\\:\\:ask\\(\\)\\.$#"
count: 1
path: src/Command/ActivateUserCommand.php

-
message: "#^Only booleans are allowed in a negated boolean, mixed given\\.$#"
count: 1
path: src/Command/ActivateUserCommand.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Console\\\\Helper\\\\HelperInterface\\:\\:ask\\(\\)\\.$#"
count: 1
path: src/Command/ChangePasswordCommand.php

-
message: "#^Only booleans are allowed in a negated boolean, mixed given\\.$#"
count: 2
path: src/Command/ChangePasswordCommand.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Console\\\\Helper\\\\HelperInterface\\:\\:ask\\(\\)\\.$#"
count: 1
path: src/Command/CreateUserCommand.php

-
message: "#^Only booleans are allowed in a negated boolean, mixed given\\.$#"
count: 4
path: src/Command/CreateUserCommand.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Console\\\\Helper\\\\HelperInterface\\:\\:ask\\(\\)\\.$#"
count: 1
path: src/Command/DeactivateUserCommand.php

-
message: "#^Only booleans are allowed in a negated boolean, mixed given\\.$#"
count: 1
path: src/Command/DeactivateUserCommand.php

-
message: "#^Call to an undefined method Symfony\\\\Component\\\\Console\\\\Helper\\\\HelperInterface\\:\\:ask\\(\\)\\.$#"
count: 1
path: src/Command/RoleCommand.php

-
message: "#^Only booleans are allowed in a negated boolean, mixed given\\.$#"
count: 2
Expand Down Expand Up @@ -95,6 +120,11 @@ parameters:
count: 1
path: src/EventListener/FlashListener.php

-
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertInstanceOf\\(\\) with 'Symfony\\\\\\\\Component\\\\\\\\DependencyInjection\\\\\\\\ContainerBuilder' and Symfony\\\\Component\\\\DependencyInjection\\\\ContainerBuilder will always evaluate to true\\.$#"
count: 2
path: tests/DependencyInjection/NucleosUserExtensionTest.php

-
message: "#^Method Nucleos\\\\UserBundle\\\\Tests\\\\DependencyInjection\\\\NucleosUserExtensionTest\\:\\:getEmptyConfig\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
Expand Down
45 changes: 35 additions & 10 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
@@ -1,23 +1,48 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="4.20.0@f82a70e7edfc6cf2705e9374c8a0b6a974a779ed">
<files psalm-version="5.7.7@e028ba46ba0d7f9a78bc3201c251e137383e145f">
<file src="src/Action/ChangePasswordAction.php">
<InvalidNullableReturnType occurrences="1">
<InvalidNullableReturnType>
<code>Response</code>
</InvalidNullableReturnType>
<NullableReturnStatement occurrences="1">
<code>$event-&gt;getResponse()</code>
<NullableReturnStatement>
<code><![CDATA[$event->getResponse()]]></code>
</NullableReturnStatement>
</file>
<file src="src/Action/ResetAction.php">
<InvalidNullableReturnType occurrences="1">
<InvalidNullableReturnType>
<code>Response</code>
</InvalidNullableReturnType>
<NullableReturnStatement occurrences="1">
<code>$event-&gt;getResponse()</code>
<NullableReturnStatement>
<code><![CDATA[$event->getResponse()]]></code>
</NullableReturnStatement>
</file>
<file src="src/Command/ActivateUserCommand.php">
<UndefinedInterfaceMethod>
<code>ask</code>
</UndefinedInterfaceMethod>
</file>
<file src="src/Command/ChangePasswordCommand.php">
<UndefinedInterfaceMethod>
<code>ask</code>
</UndefinedInterfaceMethod>
</file>
<file src="src/Command/CreateUserCommand.php">
<UndefinedInterfaceMethod>
<code>ask</code>
</UndefinedInterfaceMethod>
</file>
<file src="src/Command/DeactivateUserCommand.php">
<UndefinedInterfaceMethod>
<code>ask</code>
</UndefinedInterfaceMethod>
</file>
<file src="src/Command/RoleCommand.php">
<UndefinedInterfaceMethod>
<code>ask</code>
</UndefinedInterfaceMethod>
</file>
<file src="src/DependencyInjection/Configuration.php">
<UndefinedMethod occurrences="6">
<UndefinedMethod>
<code>addDefaultsIfNotSet</code>
<code>addDefaultsIfNotSet</code>
<code>addDefaultsIfNotSet</code>
Expand All @@ -27,8 +52,8 @@
</UndefinedMethod>
</file>
<file src="src/Model/User.php">
<RedundantPropertyInitializationCheck occurrences="1">
<code>isset($this-&gt;groups)</code>
<RedundantPropertyInitializationCheck>
<code><![CDATA[isset($this->groups)]]></code>
</RedundantPropertyInitializationCheck>
</file>
</files>
6 changes: 3 additions & 3 deletions vendor-bin/tools/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
"phpstan/phpstan-strict-rules": "^1.0",
"phpstan/phpstan-symfony": "^1.0",
"phpunit/phpunit": "^9.5",
"psalm/plugin-phpunit": "^0.17",
"psalm/plugin-symfony": "^3.0",
"psalm/plugin-phpunit": "^0.18",
"psalm/plugin-symfony": "^5.0",
"symfony/phpunit-bridge": "^6.0",
"vimeo/psalm": "^4.13"
"vimeo/psalm": "^5.0"
},
"config": {
"allow-plugins": {
Expand Down