Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linaria works with svg urls #1388

Merged
merged 1 commit into from Feb 9, 2022
Merged

fix: Linaria works with svg urls #1388

merged 1 commit into from Feb 9, 2022

Conversation

ntucker
Copy link
Owner

@ntucker ntucker commented Feb 9, 2022

callstack/linaria#879 breaks a lot of things:

  • urls cannot be resolved using webpack resolution rules
  • svgr cannot work because issuer queries break and we don't know we should be considering the url from a css source
  • react-refresh breaks due to detecting it is in a js file when in fact it's processing css

So we publish a loader where this is reverted.

We also introduce the url-inside linaria use case for an svg with absolute resolution to ensure this is accounted for.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

Size Change: 0 B

Total Size: 431 kB

ℹ️ View Unchanged
Filename Size
examples/typescript/dist/App.css 147 B
examples/typescript/dist/App.js 2.8 kB
examples/typescript/dist/Error-index-tsx.chunk.js 235 B
examples/typescript/dist/GQL-index-tsx.chunk.js 1.24 kB
examples/typescript/dist/Home-__tests__-home-test-tsx.chunk.js 4.77 kB
examples/typescript/dist/Home-__tests__-home-test-tsx.css 173 B
examples/typescript/dist/Home-index-tsx.chunk.js 4.66 kB
examples/typescript/dist/Home-index-tsx.css 165 B
examples/typescript/dist/index.html 330 B
examples/typescript/dist/Issues-index-tsx.chunk.js 3.52 kB
examples/typescript/dist/my.worker.js 158 B
examples/typescript/dist/polyfill.js 4.49 kB
examples/typescript/dist/PostDetail-CommentList-tsx.chunk.js 4.45 kB
examples/typescript/dist/PostDetail-index-tsx.chunk.js 1.83 kB
examples/typescript/dist/PostDetail-post-stories-tsx.chunk.js 3.9 kB
examples/typescript/dist/Posts-index-tsx.chunk.js 1.73 kB
examples/typescript/dist/Posts-PostCreate-tsx.chunk.js 1.73 kB
examples/typescript/dist/Posts-PostEdit-tsx.chunk.js 1.39 kB
examples/typescript/dist/Posts-PostForm-tsx.chunk.js 4.17 kB
examples/typescript/dist/Posts-PostListItem-tsx.chunk.js 1.32 kB
examples/typescript/dist/Posts-useForm-tsx.chunk.js 316 B
examples/typescript/dist/react.js 45.9 kB
examples/typescript/dist/redbox.chunk.js 10.7 kB
examples/typescript/dist/router.js 9.34 kB
examples/typescript/dist/Slow-index-tsx.chunk.js 409 B
examples/typescript/dist/style.css 458 B
examples/typescript/dist/User-index-tsx.chunk.js 1.94 kB
examples/typescript/dist/vendors-node_modules_ant-design_icons_es_icons_CloseCircleFilled_js-node_modules_ant-design_i-36b7c2.chunk.js 5.21 kB
examples/typescript/dist/vendors-node_modules_ant-design_icons_es_icons_InfoCircleOutlined_js-node_modules_ant-design_-f69432.chunk.js 3.87 kB
examples/typescript/dist/vendors-node_modules_antd_es_button_index_js.chunk.js 3.85 kB
examples/typescript/dist/vendors-node_modules_antd_es_form_index_js-node_modules_antd_es_input_index_js.chunk.js 22.7 kB
examples/typescript/dist/vendors-node_modules_antd_es_input_TextArea_js.chunk.js 6.79 kB
examples/typescript/dist/vendors-node_modules_antd_es_layout_index_js-node_modules_antd_es_menu_index_js-node_modules_-530fd5.css 66.1 kB
examples/typescript/dist/vendors-node_modules_antd_es_layout_index_js-node_modules_antd_es_menu_index_js-node_modules_-530fd5.js 57.7 kB
examples/typescript/dist/vendors-node_modules_antd_es_list_index_js.chunk.js 26.5 kB
examples/typescript/dist/vendors-node_modules_antd_es_page-header_index_js.chunk.js 4.93 kB
examples/typescript/dist/vendors-node_modules_antd_es_typography_index_js.chunk.js 6.47 kB
examples/typescript/dist/vendors-node_modules_moment_locale_af_js-node_modules_moment_locale_ar-dz_js-node_modules_mom-8265c7.chunk.js 79 kB
examples/typescript/dist/vendors-node_modules_path_path_js-node_modules_worker-loader_dist_runtime_inline_js.chunk.js 4.64 kB
examples/typescript/dist/vendors-node_modules_react-test-renderer_index_js.chunk.js 25.3 kB
examples/typescript/dist/vendors-node_modules_rest-hooks_core_lib_react-integration_hooks_useResource_js.chunk.js 1.33 kB
examples/typescript/dist/vendors-node_modules_rest-hooks_rest_lib_Resource_js.chunk.js 2.22 kB
examples/typescript/dist/webpack-runtime.js 1.9 kB

compressed-size-action

@ntucker ntucker merged commit 8d24f56 into master Feb 9, 2022
@ntucker ntucker deleted the fixlinaria branch February 9, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant