pkg: Require webpack-cli v4 (#51)

BREAKING CHANGE: args from period to space (e.g., --env readable) Also requires webpack-cli v4
ntucker · Oct 24, 2020 · 4cc699f · 4cc699f
1 parent 11933ef
commit 4cc699f
Show file tree

Hide file tree

Showing 8 changed files with 165 additions and 108 deletions.
diff --git a/examples/linaria/package.json b/examples/linaria/package.json
@@ -8,9 +8,9 @@
     "build": "webpack --mode=production",
     "build:server": "webpack --mode=production --target=node",
     "build:clean": "rm -rf dist",
-    "analyze": "webpack --mode=production --env.analyze",
-    "profile": "webpack --mode=production --env.profile",
-    "pkgcheck": "webpack --env.check=nobuild",
+    "analyze": "webpack --mode=production --env analyze",
+    "profile": "webpack --mode=production --env profile",
+    "pkgcheck": "webpack --env check=nobuild",
     "type-check": "tsc --noEmit",
     "format": "eslint --fix \"src/**/*.{js,ts,tsx}\"",
     "lint": "eslint \"src/**/*.{js,ts,tsx}\"",

diff --git a/examples/typescript/package.json b/examples/typescript/package.json
@@ -8,9 +8,9 @@
     "build": "webpack --mode=production",
     "build:server": "webpack --mode=production --target=node",
     "build:clean": "rm -rf dist",
-    "analyze": "webpack --mode=production --env.analyze",
-    "profile": "webpack --mode=production --env.profile",
-    "pkgcheck": "webpack --env.check=nobuild",
+    "analyze": "webpack --mode=production --env analyze",
+    "profile": "webpack --mode=production --env profile",
+    "pkgcheck": "webpack --env check=nobuild",
     "type-check": "tsc --noEmit",
     "format": "eslint --fix \"src/**/*.{js,ts,tsx}\"",
     "lint": "eslint \"src/**/*.{js,ts,tsx}\"",

diff --git a/package.json b/package.json
@@ -35,7 +35,7 @@
     "lerna": "^3.22.1",
     "typescript": "^4.0.2",
     "webpack": "^4.44.1",
-    "webpack-cli": "^3.3.12",
+    "webpack-cli": "^4.1.0",
     "webpack-dev-server": "^3.11.0"
   },
   "resolutions": {

diff --git a/packages/generator-js/src/webpack/index.ts b/packages/generator-js/src/webpack/index.ts
@@ -79,7 +79,7 @@ class WebpackGenerator extends InstallPeersMixin(BetterGenerator) {
     this.installPeers('@anansi/webpack-config', [], { dev: true });
     const devDeps = [
       '@anansi/webpack-config',
-      'webpack-cli@3',
+      'webpack-cli@4',
       'webpack-dev-server@3',
     ];
     if (this?.props?.style === 'linaria') {

diff --git a/packages/generator-js/src/webpack/templates/package.json.tpl b/packages/generator-js/src/webpack/templates/package.json.tpl
@@ -3,8 +3,8 @@
     "start": "webpack-dev-server --mode=development",
     "prod": "serve <%= assetPath %>",
     "build": "webpack --mode=production",
-    "analyze": "webpack --mode=production --env.analyze",
-    "profile": "webpack --mode=production --env.profile",
-    "pkgcheck": "webpack --env.check=nobuild"
+    "analyze": "webpack --mode=production --env analyze",
+    "profile": "webpack --mode=production --env profile",
+    "pkgcheck": "webpack --env check=nobuild"
   }
 }
diff --git a/packages/webpack-config-anansi/README.md b/packages/webpack-config-anansi/README.md
@@ -33,9 +33,9 @@ module.exports = makeConfig(options);
     "start": "webpack-dev-server --mode=development",
     "build": "webpack --mode=production",
     "build:server": "webpack --mode=production --target=node",
-    "analyze": "webpack --mode=production --env.analyze",
-    "profile": "webpack --mode=production --env.profile",
-    "pkgcheck": "webpack --env.check=nobuild",
+    "analyze": "webpack --mode=production --env analyze",
+    "profile": "webpack --mode=production --env profile",
+    "pkgcheck": "webpack --env check=nobuild",
   }
 }
 ```
@@ -67,26 +67,26 @@ yarn add --dev react-refresh
 
 If set, will build a static [treemap visualization of your packages](https://www.npmjs.com/package/webpack-bundle-analyzer). Highly recommended to run in production mode to get accurate results.
 
-`webpack --mode=production --env.analyze`
+`webpack --mode=production --env analyze`
 
 ### check
 
 If set will run package checks to check for duplicates or ciruclar dependencies. Set equal to 'nobuild' for a standalone run where build output is not needed.
 
 Examples:
-`webpack --mode=production --env.check` or `webpack --env.check=nobuild`
+`webpack --mode=production --env check` or `webpack --env check=nobuild`
 
 ### profile
 
 If set, will enable [React DevTools Profiler](https://reactjs.org/blog/2018/09/10/introducing-the-react-profiler.html). This feature is only available in production mode since it is enabled in development by default.
 
-`webpack --mode=production --env.profile`
+`webpack --mode=production --env profile`
 
 ### readable
 
 Skips minification. This is useful when trying to debug production code.
 
-`webpack --mode=production --env.readable`
+`webpack --mode=production --env readable`
 
 ### target
 

diff --git a/packages/webpack-config-anansi/package.json b/packages/webpack-config-anansi/package.json
@@ -95,7 +95,8 @@
     "@hot-loader/react-dom": "^16.0.0",
     "@storybook/react": "^6.0.0",
     "react-refresh": "^0.8.0",
-    "webpack": "^4.43.0 || ^5.0.0-beta.28"
+    "webpack": "^4.43.0 || ^5.0.0-beta.28",
+    "webpack-cli": "^4.1.0"
   },
   "peerDependenciesMeta": {
     "react-refresh": {
@@ -106,6 +107,9 @@
     },
     "@storybook/react": {
       "optional": true
+    },
+    "webpack-cli": {
+      "optional": true
     }
   }
 }