Constants Helper #189
Constants Helper #189
Conversation
- Add watch as dependency for TDD, plus 'test:watch' task - Add createConstants utility + specs
|
💥 |
|
That's clean! |
|
Looks like the app isn't launching after this, digging now. |
| 'UPDATE_CELL_EXECUTION_COUNT', | ||
| 'UPDATE_CELL_OUTPUTS', | ||
| 'UPDATE_CELL_SOURCE' | ||
| ); |
There was a problem hiding this comment.
It occurs to me that we no longer get good autocomplete with the constants being generated directly.
If we switch it back to explicit exports, we get named exports to come up complete with type information:
There was a problem hiding this comment.
Well it doesn't know the type anymore. Is that important when working with this piece of code?
There was a problem hiding this comment.
All about hints and developer experience here. I'm not going to argue either way, I noticed the limitation and pointed it out.
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
This utility makes creating constants a little less verbose and error-prone. When writing tests for it, I noticed
electron-mochadoesn't support (and probably never will support)--watch, see #18, so I addedwatchasdevDependencyand a new task for running tests on file changes.