Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c# 12 primary constructors #812

Merged
merged 2 commits into from
May 20, 2024
Merged

Use c# 12 primary constructors #812

merged 2 commits into from
May 20, 2024

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented May 14, 2024

Changes:

  • Use c# 12 primary constructors

@Romfos Romfos marked this pull request as ready for review May 14, 2024 12:15
@Romfos
Copy link
Contributor Author

Romfos commented May 14, 2024

One more discussion point:

I can add editorconfig option in next pr (because maybe you want to merge another PR and I don't want to block them now) for this and VS will warn to use primary constructors if possible.
It will make code style more consistent.
Do we want to have it or we need to have a more flexibility at this area?

Ready to hear you opinions

@dtchepak dtchepak merged commit b7ff02c into nsubstitute:main May 20, 2024
24 checks passed
@dtchepak
Copy link
Member

Thanks @Romfos . I think it's fine to add editorconfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants