This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Support JWKs public keys #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fightingtheboss
force-pushed
the
support_jwks_keys
branch
from
a1c20fe
to
eb7c04d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to resolve issue #123 for now.
Instead of creating an abstraction, I included the
json-jwtlibrary and conditionally use that to decode the token when theKnock.token_public_keyis set to a valid URL. All claims verifications still go throughJWT::Verifyas they did before.This turned out to be the quickest path to adding this functionality into Knock. As per this issue, JWKs may end up being supported in v2.0 of the
jwtgem, at which point a refactor can be done to remove the dependency onjson-jwt.