Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): better error logging for broken compilation #8488

Closed

Conversation

mandarini
Copy link
Member

Suggest the command format that the user should run in order to fix their compilation errors.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5zDg8FaHBivdGE8s2MHxwnZfH685
✅ Preview: Canceled

[Deployment for 47a4fa4 canceled]

@mandarini mandarini force-pushed the fix/storybook-compilation-warning branch from 8b4c1bf to 47a4fa4 Compare January 12, 2022 12:21
@@ -80,6 +88,19 @@ function runInstance(options: StorybookExecutorOptions) {
`
);

logger.warn(
`
If you are experiencing compilation issues (eg. files missing from your compilation),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 why would this be required? Do we know what the underlying issue is here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the default project missing. I should create a fix in the actual code to do that automatically, I guess. But until that is in place, I thought a better log would be useful/helpful

@mandarini mandarini linked an issue Jan 12, 2022 that may be closed by this pull request
@mandarini mandarini closed this Feb 1, 2022
@mandarini mandarini deleted the fix/storybook-compilation-warning branch March 18, 2022 14:47
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook fails to launch without a default project
2 participants