-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storybook): better error logging for broken compilation #8488
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/5zDg8FaHBivdGE8s2MHxwnZfH685 [Deployment for 47a4fa4 canceled] |
8b4c1bf
to
47a4fa4
Compare
@@ -80,6 +88,19 @@ function runInstance(options: StorybookExecutorOptions) { | |||
` | |||
); | |||
|
|||
logger.warn( | |||
` | |||
If you are experiencing compilation issues (eg. files missing from your compilation), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 why would this be required? Do we know what the underlying issue is here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's the default project missing. I should create a fix in the actual code to do that automatically, I guess. But until that is in place, I thought a better log would be useful/helpful
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Suggest the command format that the user should run in order to fix their compilation errors.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #