Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): rename languageSettings to languageOptions for flat config migration #22924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pumano
Copy link
Contributor

@pumano pumano commented Apr 20, 2024

partially fixes #22782

Current Behavior

after run migration eslint to flat config it migrate parserOptions to languageSettings, while eslint does not have that, and have languageOptions

Expected Behavior

migrate to languageOptions

Related Issue(s)

@pumano pumano requested a review from a team as a code owner April 20, 2024 08:21
@pumano pumano requested a review from JamesHenry April 20, 2024 08:21
Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 1:20pm

@pumano pumano force-pushed the fix/language-options-eslint-migration branch from 4a7001a to 59e17cb Compare April 22, 2024 13:19
@pumano
Copy link
Contributor Author

pumano commented Apr 24, 2024

@meeroslav would love if you can check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The @nx/eslint:convert-to-flat-config migration generator does not migrate parserOptions property correctly
2 participants