feat(core): add project sizes to project graph metadata #22772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c2d77c1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Cammisuli
force-pushed
the
feature/nxa-40-add-file-sizes-to-the-workspace-context-file-archive
branch
from
e752b31
to
4461651
Compare
Cammisuli
added
the
PR status: do not merge
Cammisuli
force-pushed
the
feature/nxa-40-add-file-sizes-to-the-workspace-context-file-archive
branch
from
4461651
to
3bbc036
Compare
Cammisuli
removed
the
PR status: do not merge
Cammisuli
force-pushed
the
feature/nxa-40-add-file-sizes-to-the-workspace-context-file-archive
branch
from
3bbc036
to
a6a594c
Compare
Cammisuli
changed the title
AgentEnder
approved these changes
May 9, 2024
There was a problem hiding this comment.
I don't love that this changes public API, but reckon its fine
Cammisuli
force-pushed
the
feature/nxa-40-add-file-sizes-to-the-workspace-context-file-archive
branch
from
6f00583
to
c2d77c1
Compare
|
We're going with a different direction, and wont be needing this atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
File sizes are not included in the project graph
Expected Behavior
Files sizes are now stored in the file archive file, and then appear in the proper area in the project graph metadata
Related Issue(s)
Fixes #