docs(misc): change http:// to https://

[beeman]

Current Behavior

I found a few typos (and http:// that could be https://) while looking through the Nx source code.

Expected Behavior

It has fewer typos.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Jan 30, 2024 4:27pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c119e4b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

⌛ The following target is in progress

• nx affected --targets=lint,test,build --base=6f245be10c63b3005e699c41f1bb16bb57f47aa7 --head=c119e4bc5071052dc6a651f33746a6ead800bf95 --parallel=3

✅ Successfully ran 4 targets

• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=6f245be10c63b3005e699c41f1bb16bb57f47aa7 --head=c119e4bc5071052dc6a651f33746a6ead800bf95
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=6f245be10c63b3005e699c41f1bb16bb57f47aa7 --head=c119e4bc5071052dc6a651f33746a6ead800bf95

---

Sent with 💌 from NxCloud.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 65c4487. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --target=e2e --base=0b3e1f6ec4974c8826f410cc04bb08b53ff16dd4 --head=65c448727d2b6b00fea27f7f374989712cff8cec --parallel=1
• nx affected --targets=lint,test,build --base=0b3e1f6ec4974c8826f410cc04bb08b53ff16dd4 --head=65c448727d2b6b00fea27f7f374989712cff8cec --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=0b3e1f6ec4974c8826f410cc04bb08b53ff16dd4 --head=65c448727d2b6b00fea27f7f374989712cff8cec
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=0b3e1f6ec4974c8826f410cc04bb08b53ff16dd4 --head=65c448727d2b6b00fea27f7f374989712cff8cec

---

Sent with 💌 from NxCloud.

[marleypowell]

This appears to have broken some stuff when running storybook commands

Error: no schema with key or ref "https://json-schema.org/schema"
    at Ajv.validate (C:\repo\node_modules\ajv\lib\core.ts:359:21)
    at Ajv.validateSchema (C:\repo\node_modules\ajv\lib\core.ts:515:24)
    at Ajv._addSchema (C:\repo\node_modules\ajv\lib\core.ts:721:30)
    at Ajv.compile (C:\repo\node_modules\ajv\lib\core.ts:384:22)
    at CoreSchemaRegistry._compile (C:\repo\node_modules\@angular-devkit\core\src\json\schema\registry.js:246:35)
    at CoreSchemaRegistry.compile (C:\repo\node_modules\@angular-devkit\core\src\json\schema\registry.js:231:37)
    at name (C:\repo\node_modules\@angular-devkit\architect\src\architect.js:224:43)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

[mandarini]

@marleypowell o no!!! what version of Nx are you using? do you a repro repo??

[marleypowell]

It started after this package update.

I can try and get a repro repo.

[mandarini]

@marleypowell what command are you running that's failing?

a repro repo would be SUPER helpful, thanks!!!!

[marleypowell]

@marleypowell what command are you running that's failing?

a repro repo would be SUPER helpful, thanks!!!!

yarn nx storybook <project>

[marleypowell]

I haven't got a repro just yet but I've narrowed it down to the ng-packagr-lite executor.

https://github.com/beeman/nx/blob/65c448727d2b6b00fea27f7f374989712cff8cec/packages/angular/src/executors/ng-packagr-lite/schema.json

[mandarini]

Hmm just tried it, I could not reproduce: https://github.com/mandarini/storybook-nx-17.3.1 (see README)

Do you want to try to delete node_modules and install again? Maybe some weird caching issue.

[marleypowell]

Yeah I can't reproduce it in a clean repo either. Trying to work out what's different...

It's happening to everyone for the same repository and multiple people have reinstalled node_modules but it still happens 😕

[mandarini]

I assume you cannot share your repo, right?

[marleypowell]

Figured out the problem... browserTarget pointing to build vs build-storybook.

I remember I switched them a year ago to use just build (don't remember why). But it's a bit confusing as they both work and some of the documentation still has just build

[mandarini]

Ohh thanks for pointing this out!! I suggest, specifically for Angular + Storybook, you check out the official https://storybook.js.org/tutorials/intro-to-storybook/angular/en/get-started/ documentation. The Nx Storybook docs are fine (I've written them :P) but sometimes I may have missed some update in the official Storybook docs! I should remove some of the Nx+Storybook docs that are overlapping, I guess 😬

[marleypowell]

Some of the storybook docs say to use build 😁

[marleypowell]

Oh this is why I changed it from build-storybook to build.

{
  "browserTarget": {
      "type": "string",
      "description": "Build target to be served in project-name:builder:config format. Should generally target on the builder: '@angular-devkit/build-angular:browser'. Useful for Storybook to use options (styles, assets, ...).",
      "pattern": "^[^:\\s]+:[^:\\s]+(:[^\\s]+)?$",
      "default": null
    },
}

[mandarini]

Ohhhh I see!!!! So you got it working now with build or build-storybook? Glad you got it working in any case hehehe

[marleypowell]

build-storybook works (this is what NX generates). build doesn't work (this is what storybook generates/recommends). This then causes the schema issues when invoking the @nx/angular:ng-packagr-lite executor.

If your repro repo you should be able to test the difference between build-storybook and build.

[mandarini]

Perfect, thanks!!

[marleypowell]

Oh I forgot to mention, it has to be a buildable lib.

It could be useful for the docs to have a clear distinction between buildable and non buildable libs.
storybookjs/storybook#16977 (comment)

[mandarini]

oh wow interesting! nice to see my comments from 2 years ago 😅 thanks for linking these

[marleypowell]

@mandarini should I create a new issue for this?

[mandarini]

oh yes sure please do and I'll assign myself!

[marleypowell]

oh yes sure please do and I'll assign myself!

#21636

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.