feat(backend): set nestjs target to es2017 and add incremental flag

[mehrad-rafigh]

Current Behavior (This is the behavior we have today, before the PR is merged)

target is set to es2015

Expected Behavior (This is the new behavior we can expect after the PR is merged)

target is set to es2017 and incremental flag has been set to true

Issue

Closes #1002

[vsavkin]

The PR looks good. One thing that is left is adding a migration that will update the version of nest in existing projects. This is an example:

https://github.com/nrwl/nx/blob/master/packages/workspace/src/migrations/update-8-3-0/update-ng-cli-8-1.ts

[mehrad-rafigh]

Hi @vsavkin. Thank you for reviewing the PR. I will update this PR asap

[mehrad-rafigh]

Hi @vsavkin. I updated my PR. It includes a migration and I added a test for it as well.
Should we also update the corresponding tsconfig.json files to include the target and incremental flag?

[vsavkin]

@mehrad-rafigh

Quick question. Since we are bunlding nestjs apps with webpack, how does "incremental" work together with webpack? Cause all the compilation happens in memory.

[mehrad-rafigh]

Hi @vsavkin.
I took a closer look into ts-loader and it seems, the incremental flag would be ignored by the ts-loader. The incremental flag has not been implemented by the ts-loader and there is an open issue

I would suggest to remove the incremental flag for the time being and open a PR, once the issue has been resolved.

What do you think?

[vsavkin]

@mehrad-rafigh it sounds good. let's wait for it to land and then open the PR.

[vsavkin]

I'm sorry but I'm going to close this. We changed the way we are handling package updates to use updatePackagesInPackageJson.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.