Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): skip npm nested lockfile key mismatch #13872

Merged
merged 1 commit into from Dec 19, 2022
Merged

fix(core): skip npm nested lockfile key mismatch #13872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/nx/src/lock-file/npm.ts
View file
Open in desktop
Expand Up @@ -114,13 +114,21 @@ function mapPackages(
if (lockfileVersion === 2) {
const path = packagePath.split(/\/?node_modules\//).slice(1);

path.forEach((proj) => {
if (!dependency) {
dependency = dependencies[proj];
let index = 1;
dependency = dependencies[path[0]];
while (index < path.length) {
// the root lockfile might not match the nested project's lockfile
// given path might not exist in the root lockfile
if (
dependency?.dependencies &&
dependency.dependencies[path[index]]
) {
dependency = dependency.dependencies[path[index]];
index++;
} else {
dependency = dependency.dependencies[proj];
break;
}
});
}
// if versions are same, no need to track it further
if (dependency && value.version === dependency.version) {
dependency = undefined;
Expand Down