Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): upgrade expo to 47 #13609

Merged
merged 1 commit into from Dec 5, 2022
Merged

feat(expo): upgrade expo to 47 #13609

merged 1 commit into from Dec 5, 2022

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Dec 2, 2022

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from jaysoo December 2, 2022 22:28
@vercel
Copy link

vercel bot commented Dec 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 2, 2022 at 11:03PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eac46de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaysoo jaysoo merged commit 7ad7aa6 into master Dec 5, 2022
@yonitou
Copy link

yonitou commented Dec 12, 2022

Hey !
Seems like you forgot to update the expo version in the peer dependencies of the @nrwl/expo package. When will it be updated ? It's causing issues that make us use --legacy-peer-deps with npm.
Thanks

@xiongemi
Copy link
Collaborator Author

Yes. i forgot to update it. i just submit pr to update it #13780

@Phillip9587
Copy link
Contributor

@xiongemi There was already a PR to update that: #13747

@xiongemi xiongemi deleted the feature/upgrade-expo-47 branch January 16, 2023 19:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants