Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): e2e test should correctly fail #13373

Merged
merged 1 commit into from Nov 24, 2022
Merged

fix(angular): e2e test should correctly fail #13373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions e2e/angular-core/src/projects.test.ts
View file
Open in desktop
Expand Up @@ -385,6 +385,7 @@ describe('Angular Projects', () => {
});
} catch (err) {
console.error(err);
throw err;
}

// port and process cleanup
Expand Down
3 changes: 3 additions & 0 deletions packages/angular/src/generators/remote/lib/add-ssr.ts
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ import type { Schema } from '../schema';
import setupSsr from '../../setup-ssr/setup-ssr';
import {
corsVersion,
expressVersion,
moduleFederationNodeVersion,
} from '../../../utils/versions';

Expand All @@ -34,6 +35,7 @@ export async function addSsr(tree: Tree, options: Schema, appName: string) {
appName,
tmpl: '',
});
console.log('after generate files');

// update project.json
project = readProjectConfiguration(tree, appName);
Expand All @@ -49,6 +51,7 @@ export async function addSsr(tree: Tree, options: Schema, appName: string) {
tree,
{
cors: corsVersion,
express: expressVersion,
'@module-federation/node': moduleFederationNodeVersion,
},
{}
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/src/generators/remote/remote.spec.ts
View file
Open in desktop
Expand Up @@ -199,7 +199,7 @@ describe('MF Remote App Generator', () => {
describe('--ssr', () => {
it('should generate the correct files', async () => {
// ARRANGE
const tree = createTreeWithEmptyWorkspace();
const tree = createTreeWithEmptyWorkspace({ layout: 'apps-libs' });

// ACT
await remote(tree, {
Expand Down
1 change: 1 addition & 0 deletions packages/angular/src/utils/versions.ts
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ export const tsLibVersion = '^2.3.0';

export const ngUniversalVersion = '~15.0.0';
export const corsVersion = '~2.8.5';
export const expressVersion = '~4.18.2';
export const moduleFederationNodeVersion = '~0.9.6';

export const angularEslintVersion = '~15.0.0';
Expand Down