Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): fix exclude entries for .lib.swcrc file to exclude spe… #13319

Merged
merged 1 commit into from Nov 22, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Nov 22, 2022

…c files correctly

Current Behavior

if you have a file ending with test.ts or spec.ts, it'll be ignored by SWC because the .*.spec.tsx?$ or .*.test.tsx?$ pattern matched it.

Expected Behavior

Files should not be ignored unless it is a spec file.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 22, 2022 at 3:14PM (UTC)

@jaysoo jaysoo requested a review from nartc November 22, 2022 14:06
@jaysoo jaysoo merged commit 1b3abbd into nrwl:master Nov 22, 2022
@jaysoo jaysoo deleted the fix/swc-exclude branch November 22, 2022 15:21
FrozenPandaz pushed a commit that referenced this pull request Nov 28, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants