Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): apply compatibility layer when running angular cli migrations #13231

Merged
merged 1 commit into from Nov 17, 2022
Merged

fix(core): apply compatibility layer when running angular cli migrations #13231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/nx/src/command-line/migrate.ts
View file
Open in desktop
Expand Up @@ -932,6 +932,13 @@ export async function executeMigrations(
const depsBeforeMigrations = getStringifiedPackageJsonDeps(root);

const migrationsWithNoChanges: typeof migrations = [];

let ngCliAdapter: typeof import('../adapter/ngcli-adapter');
if (migrations.some((m) => m.cli !== 'nx')) {
ngCliAdapter = await import('../adapter/ngcli-adapter');
require('../adapter/compat');
}

for (const m of migrations) {
try {
if (m.cli === 'nx') {
Expand All @@ -947,9 +954,12 @@ export async function executeMigrations(
logger.info(` ${m.description}\n`);
printChanges(changes, ' ');
} else {
const { madeChanges, loggingQueue } = await (
await import('../adapter/ngcli-adapter')
).runMigration(root, m.package, m.name, isVerbose);
const { madeChanges, loggingQueue } = await ngCliAdapter.runMigration(
root,
m.package,
m.name,
isVerbose
);

if (!madeChanges) {
migrationsWithNoChanges.push(m);
Expand Down