fix(nextjs): guard against missing webpack-loader 'issuer' field #13006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next.js v13+ removed the 'issuer' field from their css/sass loaders. This breaks the nx-next plugin 'withNx'. This PR just adds a check to ensure the 'issuer' field is still there. Not the most robust fix but it should at least maintain backwards-compatibility w/ folks using next.js < 13. ISSUES CLOSED: nrwl#12916, nrwl#12912
Nx Cloud ReportCI is running for commit 4c5e28c. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This looks almost the same as #12973 but it's missing one line. |
|
Ah, I didn't see that! My bad. I'll close this one. |
|
Thank you so much for looking into this :) really appreciate the quick fix! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.js v13+ removed the 'issuer' field from their css/sass loaders. This breaks the nx-next plugin 'withNx'. This PR just adds a check to ensure the 'issuer' field is still there. Not the most robust fix but it should at least maintain backwards-compatibility w/ folks using next.js < 13.
ISSUES CLOSED: #12916, #12912
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #