Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): atomic writes of nxdeps.json #12920

Merged
merged 1 commit into from Nov 17, 2022

Commits on Nov 15, 2022

  1. fix(core): atomic writes of nxdeps.json

    When writing nxdeps.json prevent parallel processes from seing half-written files
    and prevent half written files to be left in case of process crash tob
    
    The issue marked as closed by this has not been reproducible, so
    this fix was done based only on reading the issue description and
    code inspection.
    
    It may be that the problem is caused by something else, but even
    if this PR turns out not to solve the problem it introduces very
    little complexity, and should be completely safe, and with some
    likelyhood will solve or at least improve the issue
    
    If the problem persists this change will log some info about
    the error that occurred but will proceed without saving the cache
    
    ISSUES CLOSED: nrwl#9146
    jonhamm authored and FrozenPandaz committed Nov 15, 2022
    Copy the full SHA
    6837280 View commit details
    Browse the repository at this point in the history