Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix custom workspace-generator options #12821

Merged
merged 6 commits into from Nov 7, 2022
Merged

fix(core): fix custom workspace-generator options #12821

merged 6 commits into from Nov 7, 2022

Commits on Oct 25, 2022

  1. fix(core): fix custom workspace-generator options 

    After PR 12258 the custom options for local workspace-generators did not work anymore
because if any
options are defined in the schema it added (options) to the command
and if no properties were
defined it also throwed an error

ISSUES CLOSED: 12677
    @Roozenboom
    Roozenboom committed Oct 25, 2022
    Copy the full SHA
    0152c0d View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. fix(core): use null coalescing operator to check if property exists 

    improve fix by using null coalescing operator after recieving feedback
    @Roozenboom
    Roozenboom committed Oct 26, 2022
    Copy the full SHA
    53498d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge remote-tracking branch 'origin/master' into bugfix/custom-works… 

    …pace-generator-options
    @Roozenboom
    Roozenboom committed Nov 3, 2022
    Copy the full SHA
    2d6e4ea View commit details
    Browse the repository at this point in the history

  2. fix(core): resolve merge conflict and use null coalescing operator fo… 

    …r schema.properties
    @Roozenboom
    Roozenboom committed Nov 3, 2022
    Copy the full SHA
    fb625ee View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge remote-tracking branch 'origin/master' into bugfix/custom-works… 

    …pace-generator-options
    @Roozenboom
    Roozenboom committed Nov 7, 2022
    Copy the full SHA
    9ad9cbd View commit details
    Browse the repository at this point in the history

  2. fix(core): only add null coalescing 

    revert prop.default which was accidently removed after previous fix
    @Roozenboom
    Roozenboom committed Nov 7, 2022
    Copy the full SHA
    1fb975b View commit details
    Browse the repository at this point in the history