Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): ensure lock file is read from the correct folder #12294

Merged
merged 1 commit into from Sep 28, 2022
Merged

fix(core): ensure lock file is read from the correct folder #12294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 11 additions & 9 deletions packages/nx/src/utils/lock-file/lock-file.ts
View file
Open in desktop
Expand Up @@ -16,23 +16,25 @@ import {
stringifyPnpmLockFile,
} from './pnpm';
import { LockFileData } from './lock-file-type';
import { workspaceRoot } from '../workspace-root';
import { join } from 'path';

/**
* Parses lock file and maps dependencies and metadata to {@link LockFileData}
*/
export function parseLockFile(
packageManager: PackageManager = detectPackageManager()
packageManager: PackageManager = detectPackageManager(workspaceRoot)
): LockFileData {
if (packageManager === 'yarn') {
const file = readFileSync('yarn.lock', 'utf8');
const file = readFileSync(join(workspaceRoot, 'yarn.lock'), 'utf8');
return parseYarnLockFile(file);
}
if (packageManager === 'pnpm') {
const file = readFileSync('pnpm-lock.yaml', 'utf8');
const file = readFileSync(join(workspaceRoot, 'pnpm-lock.yaml'), 'utf8');
return parsePnpmLockFile(file);
}
if (packageManager === 'npm') {
const file = readFileSync('package-lock.json', 'utf8');
const file = readFileSync(join(workspaceRoot, 'package-lock.json'), 'utf8');
return parseNpmLockFile(file);
}
throw Error(`Unknown package manager: ${packageManager}`);
Expand All @@ -43,21 +45,21 @@ export function parseLockFile(
*/
export function writeLockFile(
lockFile: LockFileData,
packageManager: PackageManager = detectPackageManager()
packageManager: PackageManager = detectPackageManager(workspaceRoot)
): void {
if (packageManager === 'yarn') {
const content = stringifyYarnLockFile(lockFile);
writeFileSync('yarn.lock', content);
writeFileSync(join(workspaceRoot, 'yarn.lock'), content);
return;
}
if (packageManager === 'pnpm') {
const content = stringifyPnpmLockFile(lockFile);
writeFileSync('pnpm-lock.yaml', content);
writeFileSync(join(workspaceRoot, 'pnpm-lock.yaml'), content);
return;
}
if (packageManager === 'npm') {
const content = stringifyNpmLockFile(lockFile);
writeFileSync('package-lock.json', content);
writeFileSync(join(workspaceRoot, 'package-lock.json'), content);
return;
}
throw Error(`Unknown package manager: ${packageManager}`);
Expand All @@ -70,7 +72,7 @@ export function writeLockFile(
export function pruneLockFile(
lockFile: LockFileData,
packages: string[],
packageManager: PackageManager = detectPackageManager()
packageManager: PackageManager = detectPackageManager(workspaceRoot)
): LockFileData {
if (packageManager === 'yarn') {
return pruneYarnLockFile(lockFile, packages);
Expand Down