Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expo-cli package and update references to use @expo/cli #12154

Closed
wants to merge 1 commit into from
Closed

Remove expo-cli package and update references to use @expo/cli #12154

wants to merge 1 commit into from

Conversation

impleri
Copy link

@impleri impleri commented Sep 21, 2022

Port of nrwl/nx-labs#120

As of Expo SDK 46, expo-cli is deprecated and can be removed in favor of @expo/cli which is bundled in the expo installation now.

Current Behavior

We are currently using expo-cli along with Expo SDK 46. However, expo-cli does not support Node v18, so this causes issues when installing dependencies without using the --ignore-engines flag in yarn. Simply removing the package breaks functionality because @nrwl/expo command wrappers are stil pointing to expo-cli package.

Expected Behavior

  • Node v18 support, package managers can install/update without --ignore-engines flag.
  • @nrwl/expo command wrappers function without expo-cli installed.

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 21, 2022 at 4:24PM (UTC)

@xiongemi
Copy link
Collaborator

thanks for submitting the pr. i include the fix in pr: #12799

@AgentEnder
Copy link
Member

I'm closing this out since the changes were integrated as mentioned by @xiongemi

@AgentEnder AgentEnder closed this Oct 25, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants