fix(linter): align reportUnusedDisableDirectives default value #13284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The NX linter:eslint executor currently runs ESLint with
reportUnusedDisableDirectives
set as"off"
by default when the property is not defined in executor options. This is not aligned with the default ESLint behaviour which defines this property asundefined
.This lack of alignment with the current ESLint default can be problematic for some plugins, such as eslint-plugin-eslint-comments which will try to cast this option to boolean, and can cause results from running lint with ESLint CLI and the NX ESLint executor to be different.
Expected Behavior
The
reportUnusedDisableDirectives
is undefined by default when this options if not defined in the executor options.Related Issue(s)
#13241
Fixes #13241