Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): align reportUnusedDisableDirectives default value #13284

Conversation

palexandrefernandes
Copy link
Contributor

@palexandrefernandes palexandrefernandes commented Nov 21, 2022

Current Behavior

The NX linter:eslint executor currently runs ESLint with reportUnusedDisableDirectives set as "off" by default when the property is not defined in executor options. This is not aligned with the default ESLint behaviour which defines this property as undefined.

This lack of alignment with the current ESLint default can be problematic for some plugins, such as eslint-plugin-eslint-comments which will try to cast this option to boolean, and can cause results from running lint with ESLint CLI and the NX ESLint executor to be different.

Expected Behavior

The reportUnusedDisableDirectives is undefined by default when this options if not defined in the executor options.

Related Issue(s)

#13241

Fixes #13241

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 11:40AM (UTC)

@meeroslav
Copy link
Contributor

Thank you for the PR @palexandrefernandes

@meeroslav meeroslav self-assigned this Nov 21, 2022
FrozenPandaz pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: pfernandes <paulo.fernandes@dashlane.com>
(cherry picked from commit 2772fab)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eslint executor has a conflict with another plugin
2 participants