fix(linter): align reportUnusedDisableDirectives default value (#13284)

Co-authored-by: pfernandes <paulo.fernandes@dashlane.com>
nrwl · Nov 21, 2022 · 2772fab · 2772fab · vercel · Nov 21, 2022
1 parent 7f48023
commit 2772fab
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/docs/generated/packages/linter.json b/docs/generated/packages/linter.json
@@ -206,7 +206,6 @@
           },
           "reportUnusedDisableDirectives": {
             "type": "string",
-            "default": "off",
             "enum": ["off", "warn", "error"],
             "description": "The equivalent of the `--report-unused-disable-directives` flag on the ESLint CLI."
           }

diff --git a/packages/linter/src/executors/eslint/schema.json b/packages/linter/src/executors/eslint/schema.json
@@ -126,7 +126,6 @@
     },
     "reportUnusedDisableDirectives": {
       "type": "string",
-      "default": "off",
       "enum": ["off", "warn", "error"],
       "description": "The equivalent of the `--report-unused-disable-directives` flag on the ESLint CLI."
     }

diff --git a/packages/linter/src/executors/eslint/utility/eslint-utils.spec.ts b/packages/linter/src/executors/eslint/utility/eslint-utils.spec.ts
@@ -156,5 +156,15 @@ describe('eslint-utils', () => {
         useEslintrc: true,
       });
     });
+
+    it('should create a ESLint instance with no "reportUnusedDisableDirectives" if it is undefined', async () => {
+      await lint(undefined, {});
+
+      expect(ESLint).toHaveBeenCalledWith(
+        expect.objectContaining({
+          reportUnusedDisableDirectives: undefined,
+        })
+      );
+    });
   });
 });