fix(core): atomic writes of nxdeps.json #12920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
When writing nxdeps.json prevent parallel processes from seing half-written files and prevent half written files to be left in case of process crash tob The issue marked as closed by this has not been reproducible, so this fix was done based only on reading the issue description and code inspection. It may be that the problem is caused by something else, but even if this PR turns out not to solve the problem it introduces very little complexity, and should be completely safe, and with some likelyhood will solve or at least improve the issue If the problem persists this change will log some info about the error that occurred but will proceed without saving the cache ISSUES CLOSED: nrwl#9146
FrozenPandaz
force-pushed
the
atomic-write-project-graph-cache
branch
from
ef8432c
to
6837280
Compare
FrozenPandaz
approved these changes
Nov 15, 2022
|
May also fix #12389? |
Yes, that should also be fixed. 🤞 |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The issue #9146 describes how Nx will now and then experience errors because of invalid
nxdeps.jsonfile.Expected Behavior
When writing nxdeps.json prevent parallel processes from seing half-written files and prevent half written files to be left in case of process crash tob
The issue marked as closed by this has not been reproducible, so this fix was done based only on reading the issue description and code inspection.
It may be that the problem is caused by something else, but even if this PR turns out not to solve the problem it introduces very little complexity, and should be completely safe, and with some likelyhood will solve or at least improve the issue
If the problem persists this change will log some info about the error that occurred but will proceed without saving the cache
Related Issue(s)
Fixes #9146