fix(core): fix custom workspace-generator options #12821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After PR 12258 the custom options for local workspace-generators did not work anymore because if any options are defined in the schema it added (options) to the command and if no properties were defined it also throwed an error ISSUES CLOSED: 12677
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
requested changes
Oct 25, 2022
improve fix by using null coalescing operator after recieving feedback
…pace-generator-options
…r schema.properties
|
After #12955 most issues with the workspace-generators were resolved, but this PR is still resolving an existing issue when no properties object is defined in the schema.json of the generator. Can i have a review for this small changes as it is open now for almost two weeks? |
|
Since #12955 included most of the fix, can this PR be updated to only add the null safety? |
…pace-generator-options
revert prop.default which was accidently removed after previous fix
|
PR is updated to only add the null safety, because if prettier the change looks bigger than it actually is :) |
AgentEnder
approved these changes
Nov 7, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #12258 the custom options for local workspace-generators did not work anymore because if any
options are defined in the schema it added (options) to the command and if no properties were
defined it also throwed an error
ISSUES CLOSED: #12677
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #