Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): return correct webpack config for next.js storybook app #12371

Merged
merged 1 commit into from Oct 4, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 3, 2022

This MR fixes a couple of issues with the webpack configuration function from @nrwl/webpack:webpack.

  1. Default target is not set if config function is called directly, and not through the webpack executor.
  2. Default compiler is returning a conflicting webpack loader for *.tsx files. Previously this only happened if compiler is explicitly set as babel.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #12186
RyanClementsHax/storybook-addon-next#100
#12320

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Oct 4, 2022 at 2:29AM (UTC)

@jaysoo jaysoo self-assigned this Oct 3, 2022
@jaysoo jaysoo requested a review from mandarini October 3, 2022 14:54
@jaysoo jaysoo force-pushed the fix/nextjs-storybook-config branch 6 times, most recently from e5a3ac6 to b4d138d Compare October 3, 2022 16:24
@mandarini
Copy link
Member

Perfect! All works now, tried it locally! Users can now run and build Storybook for Next.js apps.

@jaysoo jaysoo force-pushed the fix/nextjs-storybook-config branch from 22e8489 to 76eac07 Compare October 4, 2022 02:26
@mandarini mandarini merged commit 5ae5f88 into nrwl:master Oct 4, 2022
@jaysoo jaysoo deleted the fix/nextjs-storybook-config branch October 4, 2022 02:37
FrozenPandaz pushed a commit that referenced this pull request Oct 4, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants