New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): return correct webpack config for next.js storybook app #12371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
fix/nextjs-storybook-config
branch
6 times, most recently
from
October 3, 2022 16:24
e5a3ac6
to
b4d138d
Compare
mandarini
approved these changes
Oct 3, 2022
Perfect! All works now, tried it locally! Users can now run and build Storybook for Next.js apps. |
jaysoo
force-pushed
the
fix/nextjs-storybook-config
branch
from
October 3, 2022 18:16
b4d138d
to
0bc6bb0
Compare
jaysoo
force-pushed
the
fix/nextjs-storybook-config
branch
4 times, most recently
from
October 4, 2022 02:07
dd445aa
to
22e8489
Compare
jaysoo
force-pushed
the
fix/nextjs-storybook-config
branch
from
October 4, 2022 02:26
22e8489
to
76eac07
Compare
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Oct 4, 2022
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes a couple of issues with the webpack configuration function from
@nrwl/webpack:webpack
.*.tsx
files. Previously this only happened if compiler is explicitly set asbabel
.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #12186
RyanClementsHax/storybook-addon-next#100
#12320