Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook-addon-next breaks storybook compilation when used with @nrwl/react/plugins/storybook #12320

Closed
ixahmedxi opened this issue Sep 29, 2022 · 4 comments · Fixed by #12371
Assignees
Labels

Comments

@ixahmedxi
Copy link
Contributor

ixahmedxi commented Sep 29, 2022

Current Behavior

When updating @nrwl/react to the latest version, the storybook config breaks if you have storybook-addon-next. There is already an open issue in the addon github repo RyanClementsHax/storybook-addon-next#100

Expected Behavior

I expect both @nrwl/react and storybook-addon-next to compile when used together fine as they used to before.

Steps to Reproduce

Just create a new storybook instance with nx that contains the storybook-addon-next package.

If you downgrade @nrwl/react to 14.7.5, the issue goes away.

Failure Logs

https://github.com/ixahmedxi/noodle/actions/runs/3151889547/jobs/5126418610

Environment

@ixahmedxi ixahmedxi changed the title storybook-addon-next breaks storybook compilation when used with @nrwl/react storybook-addon-next breaks storybook compilation when used with @nrwl/react/plugins/storybook Sep 29, 2022
@mandarini mandarini self-assigned this Sep 30, 2022
@mandarini mandarini added the scope: storybook Issues related to Storybook support in Nx label Sep 30, 2022
@mandarini
Copy link
Member

Yep, already working on this! Linking the other issue which reported it here.

@mandarini
Copy link
Member

Closing as duplicate, and will keep track in the other issue, because it has more details. Thank you for linking the addon issue as well!

@mandarini
Copy link
Member

Reproduction

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants