fix(bundling): set NODE_ENV correctly to avoid warnings

nrwl · Sep 30, 2022 · e6ad5d7 · e6ad5d7
1 parent c57f16c
commit e6ad5d7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/e2e/webpack/src/webpack.test.ts b/e2e/webpack/src/webpack.test.ts
@@ -27,6 +27,8 @@ describe('Webpack Plugin', () => {
     runCLI(`build ${myPkg}`);
     let output = runCommand(`node dist/libs/${myPkg}/main.js`);
     expect(output).toMatch(/Hello/);
+    expect(output).not.toMatch(/Conflicting/);
+    expect(output).not.toMatch(/process.env.NODE_ENV/);
 
     updateProjectConfig(myPkg, (config) => {
       delete config.targets.build;

diff --git a/packages/webpack/src/utils/config.ts b/packages/webpack/src/utils/config.ts
@@ -50,9 +50,10 @@ export function getBaseWebpackPartial(
   const chunkFilename = internalOptions.isScriptOptimizeOn
     ? `[name]${hashFormat.chunk}${suffixFormat}.js`
     : '[name].js';
-  const mode = internalOptions.isScriptOptimizeOn
-    ? 'production'
-    : 'development';
+  const mode =
+    process.env.NODE_ENV ?? internalOptions.isScriptOptimizeOn
+      ? 'production'
+      : 'development';
 
   let mainEntry = 'main';
   if (options.outputFileName) {
@@ -189,6 +190,8 @@ export function getBaseWebpackPartial(
         runtimeChunk: true,
       };
     }
+    webpackConfig.optimization ??= {};
+    webpackConfig.optimization.nodeEnv = process.env.NODE_ENV ?? mode;
   }
 
   const extraPlugins: WebpackPluginInstance[] = [];

diff --git a/packages/webpack/src/utils/webpack/partials/common.ts b/packages/webpack/src/utils/webpack/partials/common.ts
@@ -193,8 +193,6 @@ export function getCommonConfig(
   } catch {}
 
   return {
-    mode:
-      scriptsOptimization || stylesOptimization ? 'production' : 'development',
     profile: buildOptions.statsJson,
     resolve: {
       extensions: ['.ts', '.tsx', '.mjs', '.js'],