fix(core): move affected positional arguments args back to util (#12994)

nrwl · Nov 4, 2022 · d6c4547 · d6c4547 · vercel · Nov 4, 2022
1 parent 0a28a25
commit d6c4547
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 17 deletions.
diff --git a/packages/nx/src/command-line/nx-commands.ts b/packages/nx/src/command-line/nx-commands.ts
@@ -531,23 +531,6 @@ function withAffectedOptions(yargs: yargs.Argv): yargs.Argv {
       untracked: ['uncommitted', 'files', 'base', 'head', 'all'],
       uncommitted: ['files', 'untracked', 'base', 'head', 'all'],
       all: ['files', 'untracked', 'uncommitted', 'base', 'head'],
-    })
-    .check((nxArgs) => {
-      if (
-        !nxArgs.files &&
-        !nxArgs.uncommitted &&
-        !nxArgs.untracked &&
-        !nxArgs.base &&
-        !nxArgs.head &&
-        !nxArgs.all &&
-        nxArgs._ &&
-        nxArgs._.length >= 3
-      ) {
-        throw new Error(
-          `Nx no longer supports using positional arguments for base and head. Please use --base and --head instead.`
-        );
-      }
-      return true;
     });
 }
 

diff --git a/packages/nx/src/utils/command-line-utils.ts b/packages/nx/src/utils/command-line-utils.ts
@@ -100,6 +100,21 @@ export function splitArgsIntoNxArgsAndOverrides(
       });
     }
 
+    if (
+      !nxArgs.files &&
+      !nxArgs.uncommitted &&
+      !nxArgs.untracked &&
+      !nxArgs.base &&
+      !nxArgs.head &&
+      !nxArgs.all &&
+      overrides._ &&
+      overrides._.length >= 2
+    ) {
+      throw new Error(
+        `Nx no longer supports using positional arguments for base and head. Please use --base and --head instead.`
+      );
+    }
+
     // Allow setting base and head via environment variables (lower priority then direct command arguments)
     if (!nxArgs.base && process.env.NX_BASE) {
       nxArgs.base = process.env.NX_BASE;