Skip to content

Commit

Permalink
fix(core): skip npm nested lockfile key mismatch (#13872)
Browse files Browse the repository at this point in the history
  • Loading branch information
meeroslav committed Dec 19, 2022
1 parent 20c4782 commit bbfc0fb
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions packages/nx/src/lock-file/npm.ts
Expand Up @@ -114,13 +114,21 @@ function mapPackages(
if (lockfileVersion === 2) {
const path = packagePath.split(/\/?node_modules\//).slice(1);

path.forEach((proj) => {
if (!dependency) {
dependency = dependencies[proj];
let index = 1;
dependency = dependencies[path[0]];
while (index < path.length) {
// the root lockfile might not match the nested project's lockfile
// given path might not exist in the root lockfile
if (
dependency?.dependencies &&
dependency.dependencies[path[index]]
) {
dependency = dependency.dependencies[path[index]];
index++;
} else {
dependency = dependency.dependencies[proj];
break;
}
});
}
// if versions are same, no need to track it further
if (dependency && value.version === dependency.version) {
dependency = undefined;
Expand Down

1 comment on commit bbfc0fb

@vercel
Copy link

@vercel vercel bot commented on bbfc0fb Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-git-master-nrwl.vercel.app
nx-dev-nrwl.vercel.app
nx-five.vercel.app
nx.dev

Please sign in to comment.