fix(core): fix pnpm local alias

nrwl · Dec 9, 2022 · b9fb228 · b9fb228
1 parent 4f2b809
commit b9fb228
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/packages/nx/src/lock-file/__fixtures__/aux.lock.ts b/packages/nx/src/lock-file/__fixtures__/aux.lock.ts
@@ -1,3 +1,5 @@
+// TODO: add also { "eslint-plugin-disable-autofix": "npm:@mattlewis92/eslint-plugin-disable-autofix@3.0.0" } to devDependencies for test
+
 export const npmLockFileWithAliases = `{
   "name": "test",
   "version": "0.0.0",

diff --git a/packages/nx/src/lock-file/lock-file.spec.ts b/packages/nx/src/lock-file/lock-file.spec.ts
@@ -254,6 +254,8 @@ describe('lock-file', () => {
           "version": "0.0.1",
         }
       `);
+
+      expect(lockFile).toEqual(npmLockFileWithAliases);
     });
     it('should properly parse, map and stringify yarn', () => {
       const lockFileData = parseYarnLockFile(yarnLockFileWithAliases);
@@ -274,6 +276,8 @@ describe('lock-file', () => {
           "version": "0.0.1",
         }
       `);
+
+      expect(lockFile).toEqual(yarnLockFileWithAliases);
     });
     it('should properly parse, map and stringify pnpm', () => {
       const lockFileData = parsePnpmLockFile(pnpmLockFileWithAliases);
@@ -294,6 +298,8 @@ describe('lock-file', () => {
           "version": "0.0.1",
         }
       `);
+
+      expect(lockFile).toEqual(pnpmLockFileWithAliases);
     });
   });
 });
diff --git a/packages/nx/src/lock-file/utils/hashing.ts b/packages/nx/src/lock-file/utils/hashing.ts
@@ -49,13 +49,16 @@ function traverseExternalNodesDependencies(
 ) {
   graph.dependencies[projectName].forEach((d) => {
     const target = graph.externalNodes[d.target];
-    const targetKey = `${target.data.packageName}@${target.data.version}`;
-
-    if (visited.indexOf(targetKey) === -1) {
-      visited.push(targetKey);
-      if (graph.dependencies[d.target]) {
-        traverseExternalNodesDependencies(d.target, graph, visited);
+    try {
+      const targetKey = `${target.data.packageName}@${target.data.version}`;
+      if (visited.indexOf(targetKey) === -1) {
+        visited.push(targetKey);
+        if (graph.dependencies[d.target]) {
+          traverseExternalNodesDependencies(d.target, graph, visited);
+        }
       }
+    } catch (e) {
+      console.log(d.target, Object.keys(graph.externalNodes));
     }
   });
 }