fix(js): patch migration from @nrwl/node:package to @nrwl/js:tsc to r…

…ename srcRootForCompilationRoot option to rootDir (#12999)
nrwl · Nov 4, 2022 · 9cbf9bf · 9cbf9bf
1 parent 5a137d0
commit 9cbf9bf
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 0 deletions.
diff --git a/packages/node/src/migrations/update-13-8-5/update-package-to-tsc.spec.ts b/packages/node/src/migrations/update-13-8-5/update-package-to-tsc.spec.ts
@@ -67,4 +67,52 @@ describe('Migration: rename package to tsc', () => {
 
     expect(tasks).toBeUndefined();
   });
+
+  it('should migrate srcRootForCompilationRoot option to rootDir', async () => {
+    let tree = createTreeWithEmptyV1Workspace();
+
+    tree.write(
+      'workspace.json',
+      JSON.stringify({
+        version: 2,
+        projects: {
+          mylib: {
+            root: 'libs/mylib',
+            sourceRoot: 'libs/mylib/src',
+            projectType: 'library',
+            targets: {
+              build: {
+                executor: '@nrwl/node:package',
+                options: {
+                  srcRootForCompilationRoot: '.',
+                },
+              },
+            },
+          },
+        },
+      })
+    );
+
+    const tasks = await update(tree);
+
+    expect(tasks).toBeDefined();
+    expect(readJson(tree, 'workspace.json')).toEqual({
+      version: 2,
+      projects: {
+        mylib: {
+          root: 'libs/mylib',
+          sourceRoot: 'libs/mylib/src',
+          projectType: 'library',
+          targets: {
+            build: {
+              executor: '@nrwl/js:tsc',
+              options: {
+                rootDir: '.',
+              },
+            },
+          },
+        },
+      },
+    });
+  });
 });
diff --git a/packages/node/src/migrations/update-13-8-5/update-package-to-tsc.ts b/packages/node/src/migrations/update-13-8-5/update-package-to-tsc.ts
@@ -29,6 +29,18 @@ export default async function update(host: Tree) {
           transformers;
       }
 
+      if (
+        projectConfiguration.targets[targetName].options
+          ?.srcRootForCompilationRoot
+      ) {
+        projectConfiguration.targets[targetName].options.rootDir =
+          projectConfiguration.targets[
+            targetName
+          ].options.srcRootForCompilationRoot;
+        delete projectConfiguration.targets[targetName].options
+          .srcRootForCompilationRoot;
+      }
+
       updateProjectConfiguration(host, projectName, projectConfiguration);
     }
   );