fix(angular): don't set the workspaceLayout when migrating an angular…

… cli workspace to nx (#13546)
nrwl · Dec 1, 2022 · 59a6a9e · 59a6a9e
1 parent 3f05d66
commit 59a6a9e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/packages/angular/src/generators/ng-add/__snapshots__/migrate-from-angular-cli.spec.ts.snap b/packages/angular/src/generators/ng-add/__snapshots__/migrate-from-angular-cli.spec.ts.snap
@@ -36,10 +36,6 @@ Object {
       "runner": "nx/tasks-runners/default",
     },
   },
-  "workspaceLayout": Object {
-    "appsDir": "",
-    "libsDir": "",
-  },
 }
 `;
 
@@ -97,10 +93,6 @@ Object {
       "runner": "nx/tasks-runners/default",
     },
   },
-  "workspaceLayout": Object {
-    "appsDir": "projects",
-    "libsDir": "projects",
-  },
 }
 `;
 

diff --git a/packages/angular/src/generators/ng-add/migrate-from-angular-cli.ts b/packages/angular/src/generators/ng-add/migrate-from-angular-cli.ts
@@ -52,7 +52,7 @@ export async function migrateFromAngularCli(
         prettier: prettierVersion,
       }
     );
-    createNxJson(tree, options, true);
+    createNxJson(tree, options);
     decorateAngularCli(tree);
     updateVsCodeRecommendedExtensions(tree);
     await updatePrettierConfig(tree);

diff --git a/packages/angular/src/generators/ng-add/utilities/workspace.ts b/packages/angular/src/generators/ng-add/utilities/workspace.ts
@@ -43,12 +43,7 @@ export function validateWorkspace(tree: Tree): void {
   - ${errors.join('\n  ')}`);
 }
 
-export function createNxJson(
-  tree: Tree,
-  options: GeneratorOptions,
-  setWorkspaceLayoutAsNewProjectRoot: boolean = false
-): void {
-  const { newProjectRoot = '' } = readJson(tree, 'angular.json');
+export function createNxJson(tree: Tree, options: GeneratorOptions): void {
   const { npmScope } = options;
 
   const targets = getWorkspaceCommonTargets(tree);
@@ -107,9 +102,6 @@ export function createNxJson(
           }
         : undefined,
     },
-    workspaceLayout: setWorkspaceLayoutAsNewProjectRoot
-      ? { appsDir: newProjectRoot, libsDir: newProjectRoot }
-      : undefined,
   });
 }