fix(angular): e2e test should correctly fail

nrwl · Nov 24, 2022 · 5748752 · 5748752
1 parent 883b61b
commit 5748752
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/e2e/angular-core/src/projects.test.ts b/e2e/angular-core/src/projects.test.ts
@@ -375,6 +375,7 @@ describe('Angular Projects', () => {
 
     try {
       process = await runCommandUntil(`serve-ssr ${remoteApp1}`, (output) => {
+        console.log(output);
         return (
           output.includes(`Browser application bundle generation complete.`) &&
           output.includes(`Server application bundle generation complete.`) &&
@@ -385,6 +386,7 @@ describe('Angular Projects', () => {
       });
     } catch (err) {
       console.error(err);
+      throw err;
     }
 
     // port and process cleanup

diff --git a/packages/angular/src/generators/remote/lib/add-ssr.ts b/packages/angular/src/generators/remote/lib/add-ssr.ts
@@ -11,6 +11,7 @@ import type { Schema } from '../schema';
 import setupSsr from '../../setup-ssr/setup-ssr';
 import {
   corsVersion,
+  expressVersion,
   moduleFederationNodeVersion,
 } from '../../../utils/versions';
 
@@ -49,6 +50,7 @@ export async function addSsr(tree: Tree, options: Schema, appName: string) {
     tree,
     {
       cors: corsVersion,
+      express: expressVersion,
       '@module-federation/node': moduleFederationNodeVersion,
     },
     {}

diff --git a/packages/angular/src/utils/versions.ts b/packages/angular/src/utils/versions.ts
@@ -11,6 +11,7 @@ export const tsLibVersion = '^2.3.0';
 
 export const ngUniversalVersion = '~15.0.0';
 export const corsVersion = '~2.8.5';
+export const expressVersion = '~4.18.2';
 export const moduleFederationNodeVersion = '~0.9.6';
 
 export const angularEslintVersion = '~15.0.0';