fix(storybook): set projectBuildConfig in storybook configuration gen…

…erator
nrwl · Jan 17, 2022 · 552efe2 · 552efe2
1 parent ca2f5a3
commit 552efe2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/storybook/src/generators/configuration/configuration.spec.ts b/packages/storybook/src/generators/configuration/configuration.spec.ts
@@ -153,6 +153,7 @@ describe('@nrwl/storybook:configuration', () => {
       },
       options: {
         port: 4400,
+        projectBuildConfig: 'test-ui-lib:build-storybook',
         uiFramework: '@storybook/react',
         config: {
           configFolder: 'libs/test-ui-lib/.storybook',

diff --git a/packages/storybook/src/generators/configuration/configuration.ts b/packages/storybook/src/generators/configuration/configuration.ts
@@ -41,7 +41,9 @@ export async function configurationGenerator(
 
   const workspaceStorybookVersion = getCurrentWorkspaceStorybookVersion(tree);
 
-  const { projectType } = readProjectConfiguration(tree, schema.name);
+  const { projectType, targets } = readProjectConfiguration(tree, schema.name);
+
+  const buildable = !!targets?.build;
 
   const initTask = await initGenerator(tree, {
     uiFramework: schema.uiFramework,
@@ -59,7 +61,7 @@ export async function configurationGenerator(
   configureTsProjectConfig(tree, schema);
   configureTsSolutionConfig(tree, schema);
   updateLintConfig(tree, schema);
-  addStorybookTask(tree, schema.name, schema.uiFramework);
+  addStorybookTask(tree, schema.name, schema.uiFramework, buildable);
   if (schema.configureCypress) {
     if (projectType !== 'application') {
       const cypressTask = await cypressProjectGenerator(tree, {
@@ -300,7 +302,8 @@ function dedupe(arr: string[]) {
 function addStorybookTask(
   tree: Tree,
   projectName: string,
-  uiFramework: string
+  uiFramework: string,
+  buildable: boolean
 ) {
   const projectConfig = readProjectConfiguration(tree, projectName);
   projectConfig.targets['storybook'] = {
@@ -311,6 +314,9 @@ function addStorybookTask(
       config: {
         configFolder: `${projectConfig.root}/.storybook`,
       },
+      projectBuildConfig: buildable
+        ? projectName
+        : `${projectName}:build-storybook`,
     },
     configurations: {
       ci: {
@@ -327,6 +333,9 @@ function addStorybookTask(
       config: {
         configFolder: `${projectConfig.root}/.storybook`,
       },
+      projectBuildConfig: buildable
+        ? projectName
+        : `${projectName}:build-storybook`,
     },
     configurations: {
       ci: {