Skip to content

Commit

Permalink
fix(bundling): run dev-server in development mode and hmr on by defau…
Browse files Browse the repository at this point in the history
…lt (#13352)
  • Loading branch information
jaysoo committed Nov 23, 2022
1 parent 02e22de commit 2a7ccb6
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 8 deletions.
12 changes: 8 additions & 4 deletions docs/generated/packages/vite.json
Expand Up @@ -167,8 +167,8 @@
},
"hmr": {
"description": "Enable hot module replacement. For more options, use the 'hmr' option in the Vite configuration file.",
"default": false,
"type": "boolean"
"type": "boolean",
"default": true
},
"open": {
"description": "Automatically open the app in the browser on server start. When the value is a string, it will be used as the URL's pathname.",
Expand All @@ -186,7 +186,9 @@
},
"mode": {
"type": "string",
"description": "Specifying this in config will override the default mode for both serve and build."
"description": "Mode to run the server in.",
"enum": ["production", "development"],
"default": "development"
},
"clearScreen": {
"description": "Set to false to prevent Vite from clearing the terminal screen when logging certain messages.",
Expand Down Expand Up @@ -322,7 +324,9 @@
},
"mode": {
"type": "string",
"description": "Specifying this in config will override the default mode for both serve and build."
"description": "Mode to run the build in.",
"enum": ["production", "development"],
"default": "production"
}
},
"definitions": {
Expand Down
4 changes: 3 additions & 1 deletion packages/vite/src/executors/build/schema.json
Expand Up @@ -121,7 +121,9 @@
},
"mode": {
"type": "string",
"description": "Specifying this in config will override the default mode for both serve and build."
"description": "Mode to run the build in.",
"enum": ["production", "development"],
"default": "production"
}
},
"definitions": {
Expand Down
8 changes: 5 additions & 3 deletions packages/vite/src/executors/dev-server/schema.json
Expand Up @@ -49,8 +49,8 @@
},
"hmr": {
"description": "Enable hot module replacement. For more options, use the 'hmr' option in the Vite configuration file.",
"default": false,
"type": "boolean"
"type": "boolean",
"default": true
},
"open": {
"description": "Automatically open the app in the browser on server start. When the value is a string, it will be used as the URL's pathname.",
Expand All @@ -75,7 +75,9 @@
},
"mode": {
"type": "string",
"description": "Specifying this in config will override the default mode for both serve and build."
"description": "Mode to run the server in.",
"enum": ["production", "development"],
"default": "development"
},
"clearScreen": {
"description": "Set to false to prevent Vite from clearing the terminal screen when logging certain messages.",
Expand Down

1 comment on commit 2a7ccb6

@vercel
Copy link

@vercel vercel bot commented on 2a7ccb6 Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-five.vercel.app
nx-dev-nrwl.vercel.app
nx-dev-git-master-nrwl.vercel.app
nx.dev

Please sign in to comment.